[FFmpeg-cvslog] avformat/hnm: Check for extradata allocation failure
Andreas Rheinhardt
git at videolan.org
Thu Jul 2 02:29:45 EEST 2020
ffmpeg | branch: release/4.2 | Andreas Rheinhardt <andreas.rheinhardt at gmail.com> | Sat Mar 21 07:31:17 2020 +0100| [210aa29b429ca1358be1333e8949fd30008529fd] | committer: Andreas Rheinhardt
avformat/hnm: Check for extradata allocation failure
and also add padding to it; moreover, don't use memcpy to write one byte
to extradata.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
Reviewed-by: Paul B Mahol <onemda at gmail.com>
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
(cherry picked from commit 9e0f3352d1f37a739d98df4347a2b60a396a56fe)
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=210aa29b429ca1358be1333e8949fd30008529fd
---
libavformat/hnm.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/libavformat/hnm.c b/libavformat/hnm.c
index 40ef5c06ee..31221553a4 100644
--- a/libavformat/hnm.c
+++ b/libavformat/hnm.c
@@ -70,6 +70,7 @@ static int hnm_read_header(AVFormatContext *s)
Hnm4DemuxContext *hnm = s->priv_data;
AVIOContext *pb = s->pb;
AVStream *vst;
+ int ret;
/* default context members */
hnm->pts = 0;
@@ -113,10 +114,10 @@ static int hnm_read_header(AVFormatContext *s)
vst->codecpar->codec_tag = 0;
vst->codecpar->width = hnm->width;
vst->codecpar->height = hnm->height;
- vst->codecpar->extradata = av_mallocz(1);
+ if ((ret = ff_alloc_extradata(vst->codecpar, 1)) < 0)
+ return ret;
- vst->codecpar->extradata_size = 1;
- memcpy(vst->codecpar->extradata, &hnm->version, 1);
+ vst->codecpar->extradata[0] = hnm->version;
vst->start_time = 0;
More information about the ffmpeg-cvslog
mailing list