[FFmpeg-cvslog] avfilter/src_movie: Avoid intermediate buffer for writing string

Andreas Rheinhardt git at videolan.org
Mon Aug 31 05:00:00 EEST 2020


ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt at gmail.com> | Sat Aug 22 04:08:15 2020 +0200| [a97d8469a64b9416ad4f92ce503ad219470cbe7b] | committer: Andreas Rheinhardt

avfilter/src_movie: Avoid intermediate buffer for writing string

Reviewed-by: Paul B Mahol <onemda at gmail.com>
Reviewed-by: Nicolas George <george at nsup.org>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=a97d8469a64b9416ad4f92ce503ad219470cbe7b
---

 libavfilter/src_movie.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/libavfilter/src_movie.c b/libavfilter/src_movie.c
index 64d82e9df1..eeb8609855 100644
--- a/libavfilter/src_movie.c
+++ b/libavfilter/src_movie.c
@@ -213,7 +213,6 @@ static av_cold int movie_common_init(AVFilterContext *ctx)
     int64_t timestamp;
     int nb_streams = 1, ret, i;
     char default_streams[16], *stream_specs, *spec, *cursor;
-    char name[16];
     AVStream *st;
 
     if (!movie->file_name) {
@@ -305,9 +304,8 @@ static av_cold int movie_common_init(AVFilterContext *ctx)
     for (i = 0; i < nb_streams; i++) {
         AVFilterPad pad = { 0 };
         movie->out_index[movie->st[i].st->index] = i;
-        snprintf(name, sizeof(name), "out%d", i);
         pad.type          = movie->st[i].st->codecpar->codec_type;
-        pad.name          = av_strdup(name);
+        pad.name          = av_asprintf("out%d", i);
         if (!pad.name)
             return AVERROR(ENOMEM);
         pad.config_props  = movie_config_output_props;



More information about the ffmpeg-cvslog mailing list