[FFmpeg-cvslog] avformat/matroskadec: Remove redundant setting of chapter titles
Andreas Rheinhardt
git at videolan.org
Sun Apr 19 01:42:13 EEST 2020
ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt at gmail.com> | Mon Apr 13 21:56:47 2020 +0200| [3059b7746aa996d81c2dfd075f7a23efb499d7d9] | committer: Andreas Rheinhardt
avformat/matroskadec: Remove redundant setting of chapter titles
Chapter titles are added to the chapter's metadata since 6cb6e159,
yet since 012867f0 (the predecessor of) avpriv_new_chapter() already
adds the title to the chapter's metadata. So setting it again in
matroskadec.c is redundant and expensive.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=3059b7746aa996d81c2dfd075f7a23efb499d7d9
---
libavformat/matroskadec.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c
index c699ce66b8..761d8b3743 100644
--- a/libavformat/matroskadec.c
+++ b/libavformat/matroskadec.c
@@ -2933,10 +2933,6 @@ static int matroska_read_header(AVFormatContext *s)
(AVRational) { 1, 1000000000 },
chapters[i].start, chapters[i].end,
chapters[i].title);
- if (chapters[i].chapter) {
- av_dict_set(&chapters[i].chapter->metadata,
- "title", chapters[i].title, 0);
- }
max_start = chapters[i].start;
}
More information about the ffmpeg-cvslog
mailing list