[FFmpeg-cvslog] avcodec/takdec: Fix overflow with large sample rates
Michael Niedermayer
git at videolan.org
Fri Oct 25 01:25:44 EEST 2019
ffmpeg | branch: master | Michael Niedermayer <michael at niedermayer.cc> | Sat Oct 5 19:52:53 2019 +0200| [42eb78059d149abcd994f46c8b8a0dd98e86b594] | committer: Michael Niedermayer
avcodec/takdec: Fix overflow with large sample rates
Fixes: signed integer overflow: 2147483647 + 511 cannot be represented in type 'int'
Fixes: 17899/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TAK_fuzzer-5719753322135552
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=42eb78059d149abcd994f46c8b8a0dd98e86b594
---
libavcodec/takdec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/takdec.c b/libavcodec/takdec.c
index 4fb5825532..8ec87ab509 100644
--- a/libavcodec/takdec.c
+++ b/libavcodec/takdec.c
@@ -176,8 +176,8 @@ static void set_sample_rate_params(AVCodecContext *avctx)
} else {
shift = 0;
}
- s->uval = FFALIGN(avctx->sample_rate + 511 >> 9, 4) << shift;
- s->subframe_scale = FFALIGN(avctx->sample_rate + 511 >> 9, 4) << 1;
+ s->uval = FFALIGN(avctx->sample_rate + 511LL >> 9, 4) << shift;
+ s->subframe_scale = FFALIGN(avctx->sample_rate + 511LL >> 9, 4) << 1;
}
static av_cold int tak_decode_init(AVCodecContext *avctx)
More information about the ffmpeg-cvslog
mailing list