[FFmpeg-cvslog] avformat/jvdec: fix memleak when read_header failed

Steven Liu git at videolan.org
Thu Oct 10 04:59:32 EEST 2019


ffmpeg | branch: master | Steven Liu <lq at chinaffmpeg.org> | Wed Oct  9 11:56:22 2019 +0800| [6f84c1e9078b2133f3cb75d76f089196a7df96a9] | committer: Steven Liu

avformat/jvdec: fix memleak when read_header failed

Reviewed-by: Peter Ross <pross at xvid.org>
Signed-off-by: Steven Liu <lq at chinaffmpeg.org>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=6f84c1e9078b2133f3cb75d76f089196a7df96a9
---

 libavformat/jvdec.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/libavformat/jvdec.c b/libavformat/jvdec.c
index 18c81f0de7..17ada7b0f1 100644
--- a/libavformat/jvdec.c
+++ b/libavformat/jvdec.c
@@ -113,9 +113,10 @@ static int read_header(AVFormatContext *s)
         return AVERROR(ENOMEM);
 
     jv->frames = av_malloc(ast->nb_index_entries * sizeof(JVFrame));
-    if (!jv->frames)
+    if (!jv->frames) {
+        av_freep(&ast->index_entries);
         return AVERROR(ENOMEM);
-
+    }
     offset = 0x68 + ast->nb_index_entries * 16;
     for (i = 0; i < ast->nb_index_entries; i++) {
         AVIndexEntry *e   = ast->index_entries + i;
@@ -137,6 +138,8 @@ static int read_header(AVFormatContext *s)
                     - jvf->palette_size < 0) {
             if (s->error_recognition & AV_EF_EXPLODE) {
                 read_close(s);
+                av_freep(&jv->frames);
+                av_freep(&ast->index_entries);
                 return AVERROR_INVALIDDATA;
             }
             jvf->audio_size   =



More information about the ffmpeg-cvslog mailing list