[FFmpeg-cvslog] avcodec/cbs_av1: don't call cbs_av1_read_trailing_bits() when no bits remain in the OBU

James Almer git at videolan.org
Sun Feb 10 22:43:56 EET 2019


ffmpeg | branch: master | James Almer <jamrial at gmail.com> | Sun Feb 10 17:41:38 2019 -0300| [3e8b8b6b509c8c37defd3a8c32883fa54bc00de8] | committer: James Almer

avcodec/cbs_av1: don't call cbs_av1_read_trailing_bits() when no bits remain in the OBU

Reviewed-by: jkqxz
Signed-off-by: James Almer <jamrial at gmail.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=3e8b8b6b509c8c37defd3a8c32883fa54bc00de8
---

 libavcodec/cbs_av1.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/libavcodec/cbs_av1.c b/libavcodec/cbs_av1.c
index f70ff1c94f..02f168b58d 100644
--- a/libavcodec/cbs_av1.c
+++ b/libavcodec/cbs_av1.c
@@ -1067,8 +1067,12 @@ static int cbs_av1_read_unit(CodedBitstreamContext *ctx,
     if (obu->obu_size > 0 &&
         obu->header.obu_type != AV1_OBU_TILE_GROUP &&
         obu->header.obu_type != AV1_OBU_FRAME) {
-        err = cbs_av1_read_trailing_bits(ctx, &gbc,
-                                         obu->obu_size * 8 + start_pos - end_pos);
+        int nb_bits = obu->obu_size * 8 + start_pos - end_pos;
+
+        if (nb_bits <= 0)
+            return AVERROR_INVALIDDATA;
+
+        err = cbs_av1_read_trailing_bits(ctx, &gbc, nb_bits);
         if (err < 0)
             return err;
     }



More information about the ffmpeg-cvslog mailing list