[FFmpeg-cvslog] avcodec/truespeech: Fix an integer overflow in truespeech_synth()

Michael Niedermayer git at videolan.org
Tue Dec 10 17:13:38 EET 2019


ffmpeg | branch: master | Michael Niedermayer <michael at niedermayer.cc> | Thu Nov 14 16:44:10 2019 +0100| [8bcb5fbab5e30c3001c27a8309c94eb1f66b969f] | committer: Michael Niedermayer

avcodec/truespeech: Fix an integer overflow in truespeech_synth()

Fixes: signed integer overflow: 2147483188 + 2048 cannot be represented in type 'int'
Fixes: 18741/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUESPEECH_fuzzer-5748950460268544

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=8bcb5fbab5e30c3001c27a8309c94eb1f66b969f
---

 libavcodec/truespeech.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/truespeech.c b/libavcodec/truespeech.c
index d7c2d535e2..3cdae8c556 100644
--- a/libavcodec/truespeech.c
+++ b/libavcodec/truespeech.c
@@ -255,7 +255,7 @@ static void truespeech_synth(TSContext *dec, int16_t *out, int quart)
         int sum = 0;
         for(k = 0; k < 8; k++)
             sum += ptr0[k] * (unsigned)ptr1[k];
-        sum = out[i] + ((sum + 0x800) >> 12);
+        sum = out[i] + ((int)(sum + 0x800U) >> 12);
         out[i] = av_clip(sum, -0x7FFE, 0x7FFE);
         for(k = 7; k > 0; k--)
             ptr0[k] = ptr0[k - 1];



More information about the ffmpeg-cvslog mailing list