[FFmpeg-cvslog] tools/zmqsend: Avoid mem copy past the end of input buffer

Andriy Gelman git at videolan.org
Sat Aug 10 01:02:59 EEST 2019


ffmpeg | branch: master | Andriy Gelman <andriy.gelman at gmail.com> | Thu Aug  8 10:37:10 2019 -0400| [90e965be6d90fcf729b020dba675b062b59ee17d] | committer: Michael Niedermayer

tools/zmqsend: Avoid mem copy past the end of input buffer

This patch avoids a read past the end of the input buffer in memcpy since the size
of the received zmq message is recv_buf_size - 1.

Reviewed-by: Paul B Mahol <onemda at gmail.com>
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=90e965be6d90fcf729b020dba675b062b59ee17d
---

 tools/zmqsend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/zmqsend.c b/tools/zmqsend.c
index 7bd7fe4199..f26fa9c1c2 100644
--- a/tools/zmqsend.c
+++ b/tools/zmqsend.c
@@ -155,7 +155,7 @@ int main(int argc, char **argv)
         ret = 1;
         goto end;
     }
-    memcpy(recv_buf, zmq_msg_data(&msg), recv_buf_size);
+    memcpy(recv_buf, zmq_msg_data(&msg), recv_buf_size - 1);
     recv_buf[recv_buf_size-1] = 0;
     printf("%s\n", recv_buf);
     zmq_msg_close(&msg);



More information about the ffmpeg-cvslog mailing list