[FFmpeg-cvslog] lavf/dashenc: set FLAC manifest codec string to "flac"

Jan Ekström git at videolan.org
Wed Nov 14 20:47:01 EET 2018


ffmpeg | branch: master | Jan Ekström <jeebjp at gmail.com> | Wed Nov 14 03:11:31 2018 +0200| [b31a4be15f568c12be32dca87f066416e6adc8ad] | committer: Jan Ekström

lavf/dashenc: set FLAC manifest codec string to "flac"

Internally in ISOBMFF the FLAC-in-ISOBMFF draft uses "fLaC"
as the identifier for FLACSampleEntry, and there seems to be no
MPEG-DASH specification for the in-manifest identifier for FLAC.

After testing the browsers' implementations, it seems like all of
the major browser vendors have decided to utilize the MIME type for
FLAC ("audio/flac") as the identifier. This change set leads to
that string being utilized for FLAC streams instead of the sample
entry identifier ("fLaC"), which is the default behavior.

Verified by auri_ on IRC to play with the major browsers.

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=b31a4be15f568c12be32dca87f066416e6adc8ad
---

 libavformat/dashenc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
index f8b3d106d5..d151921175 100644
--- a/libavformat/dashenc.c
+++ b/libavformat/dashenc.c
@@ -143,6 +143,7 @@ static struct codec_string {
     { AV_CODEC_ID_VP9, "vp9" },
     { AV_CODEC_ID_VORBIS, "vorbis" },
     { AV_CODEC_ID_OPUS, "opus" },
+    { AV_CODEC_ID_FLAC, "flac" },
     { 0, NULL }
 };
 



More information about the ffmpeg-cvslog mailing list