[FFmpeg-cvslog] avfilter/avf_showvolume: implement basic rms metering mode

[Paul B Mahol]

ffmpeg | branch: master | Paul B Mahol <onemda at gmail.com> | Fri Mar 23 22:53:13 2018 +0100| [3e3d56776166b7529df7cc37d48a5d2a2596050b] | committer: Paul B Mahol

avfilter/avf_showvolume: implement basic rms metering mode

Signed-off-by: Paul B Mahol <onemda at gmail.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=3e3d56776166b7529df7cc37d48a5d2a2596050b
---

 doc/filters.texi             |  4 ++++
 libavfilter/avf_showvolume.c | 50 ++++++++++++++++++++++++++++++++++++++------
 2 files changed, 48 insertions(+), 6 deletions(-)

diff --git a/doc/filters.texi b/doc/filters.texi
index e684e490f0..1620ae1cfa 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
@@ -19970,6 +19970,10 @@ step is disabled.
 
 @item p
 Set background opacity, allowed range is [0, 1]. Default is 0.
+
+ at item m
+Set metering mode, can be peak: @code{p} or rms: @code{r},
+default is @code{p}.
 @end table
 
 @section showwaves
diff --git a/libavfilter/avf_showvolume.c b/libavfilter/avf_showvolume.c
index 9b836b9ad6..af8ac1da6c 100644
--- a/libavfilter/avf_showvolume.c
+++ b/libavfilter/avf_showvolume.c
@@ -44,6 +44,7 @@ typedef struct ShowVolumeContext {
     int orientation;
     int step;
     float bgopacity;
+    int mode;
 
     AVFrame *out;
     AVExpr *c_expr;
@@ -51,6 +52,10 @@ typedef struct ShowVolumeContext {
     int draw_volume;
     double *values;
     uint32_t *color_lut;
+    float *max;
+    float rms_factor;
+
+    void (*meter)(float *src, int nb_samples, float *max, float factor);
 } ShowVolumeContext;
 
 #define OFFSET(x) offsetof(ShowVolumeContext, x)
@@ -71,6 +76,9 @@ static const AVOption showvolume_options[] = {
     {   "v", "vertical",   0, AV_OPT_TYPE_CONST, {.i64=1}, 0, 0, FLAGS, "orientation" },
     { "s", "set step size", OFFSET(step), AV_OPT_TYPE_INT, {.i64=0}, 0, 5, FLAGS },
     { "p", "set background opacity", OFFSET(bgopacity), AV_OPT_TYPE_FLOAT, {.dbl=0}, 0, 1, FLAGS },
+    { "m", "set mode", OFFSET(mode), AV_OPT_TYPE_INT, {.i64=0}, 0, 1, FLAGS, "mode" },
+    {   "p", "peak", 0, AV_OPT_TYPE_CONST, {.i64=0}, 0, 0, FLAGS, "mode" },
+    {   "r", "rms",  0, AV_OPT_TYPE_CONST, {.i64=1}, 0, 0, FLAGS, "mode" },
     { NULL }
 };
 
@@ -120,6 +128,23 @@ static int query_formats(AVFilterContext *ctx)
     return 0;
 }
 
+static void find_peak(float *src, int nb_samples, float *peak, float factor)
+{
+    int i;
+
+    *peak = 0;
+    for (i = 0; i < nb_samples; i++)
+        *peak = FFMAX(*peak, FFABS(src[i]));
+}
+
+static void find_rms(float *src, int nb_samples, float *rms, float factor)
+{
+    int i;
+
+    for (i = 0; i < nb_samples; i++)
+        *rms += factor * (src[i] * src[i] - *rms);
+}
+
 static int config_input(AVFilterLink *inlink)
 {
     AVFilterContext *ctx = inlink->dst;
@@ -138,6 +163,18 @@ static int config_input(AVFilterLink *inlink)
     if (!s->color_lut)
         return AVERROR(ENOMEM);
 
+    s->max = av_calloc(inlink->channels, sizeof(*s->max));
+    if (!s->max)
+        return AVERROR(ENOMEM);
+
+    s->rms_factor = 10000. / inlink->sample_rate;
+
+    switch (s->mode) {
+    case 0: s->meter = find_peak; break;
+    case 1: s->meter = find_rms;  break;
+    default: return AVERROR_BUG;
+    }
+
     return 0;
 }
 
@@ -252,10 +289,10 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *insamples)
         for (c = 0; c < inlink->channels; c++) {
             float *src = (float *)insamples->extended_data[c];
             uint32_t *lut = s->color_lut + s->w * c;
-            float max = 0;
+            float max;
 
-            for (i = 0; i < insamples->nb_samples; i++)
-                max = FFMAX(max, src[i]);
+            s->meter(src, insamples->nb_samples, &s->max[c], s->rms_factor);
+            max = s->max[c];
 
             s->values[c * VAR_VARS_NB + VAR_VOLUME] = 20.0 * log10(max);
             max = av_clipf(max, 0, 1);
@@ -280,10 +317,10 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *insamples)
         for (c = 0; c < inlink->channels; c++) {
             float *src = (float *)insamples->extended_data[c];
             uint32_t *lut = s->color_lut + s->w * c;
-            float max = 0;
+            float max;
 
-            for (i = 0; i < insamples->nb_samples; i++)
-                max = FFMAX(max, src[i]);
+            s->meter(src, insamples->nb_samples, &s->max[c], s->rms_factor);
+            max = s->max[c];
 
             s->values[c * VAR_VARS_NB + VAR_VOLUME] = 20.0 * log10(max);
             max = av_clipf(max, 0, 1);
@@ -339,6 +376,7 @@ static av_cold void uninit(AVFilterContext *ctx)
     av_expr_free(s->c_expr);
     av_freep(&s->values);
     av_freep(&s->color_lut);
+    av_freep(&s->max);
 }
 
 static const AVFilterPad showvolume_inputs[] = {