[FFmpeg-cvslog] avcodec/hapqa_extract: fix two error return values

James Almer git at videolan.org
Wed Mar 14 01:50:30 EET 2018


ffmpeg | branch: master | James Almer <jamrial at gmail.com> | Tue Mar 13 19:06:45 2018 -0300| [b173e035362b103e17cc7b394c231c60a4915c59] | committer: James Almer

avcodec/hapqa_extract: fix two error return values

ret is 0 by default.

Reviewed-by: Martin Vignali <martin.vignali at gmail.com>
Signed-off-by: James Almer <jamrial at gmail.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=b173e035362b103e17cc7b394c231c60a4915c59
---

 libavcodec/hapqa_extract_bsf.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavcodec/hapqa_extract_bsf.c b/libavcodec/hapqa_extract_bsf.c
index 333efb2e3a..ee5dc191f7 100644
--- a/libavcodec/hapqa_extract_bsf.c
+++ b/libavcodec/hapqa_extract_bsf.c
@@ -66,6 +66,7 @@ static int hapqa_extract(AVBSFContext *bsf, AVPacket *pkt)
 
     if ((section_type & 0x0F) != 0x0D) {
         av_log(bsf, AV_LOG_ERROR, "Invalid section type for HAPQA %#04x.\n", section_type & 0x0F);
+        ret = AVERROR_INVALIDDATA;
         goto fail;
     }
 
@@ -90,6 +91,7 @@ static int hapqa_extract(AVBSFContext *bsf, AVPacket *pkt)
 
         if (check_texture(ctx, section_type) == 0){ /* the second texture is not the one to keep */
             av_log(bsf, AV_LOG_ERROR, "No valid texture found.\n");
+            ret = AVERROR_INVALIDDATA;
             goto fail;
         }
     }



More information about the ffmpeg-cvslog mailing list