[FFmpeg-cvslog] avformat/id3v2: fix leak in chapter parsing

Fredrik Hubinette git at videolan.org
Thu Oct 26 19:53:22 EEST 2017


ffmpeg | branch: release/3.3 | Fredrik Hubinette <hubbe at google.com> | Tue Feb  7 12:19:38 2017 -0800| [670d3189e9ef674e4167cec3145ea4c4c172d581] | committer: James Almer

avformat/id3v2: fix leak in chapter parsing

Reviewed-on: https://chromium-review.googlesource.com/439405
Reviewed-by: Dale Curtis <dalecurtis at chromium.org>
Signed-off-by: James Almer <jamrial at gmail.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=670d3189e9ef674e4167cec3145ea4c4c172d581
---

 libavformat/id3v2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c
index f7fa3ef856..aa0a1cbcfd 100644
--- a/libavformat/id3v2.c
+++ b/libavformat/id3v2.c
@@ -688,9 +688,9 @@ static void read_chapter(AVFormatContext *s, AVIOContext *pb, int len, const cha
     }
 
     if (decode_str(s, pb, 0, &dst, &len) < 0)
-        return;
+        goto end;
     if (len < 16)
-        return;
+        goto end;
 
     start = avio_rb32(pb);
     end   = avio_rb32(pb);



More information about the ffmpeg-cvslog mailing list