[FFmpeg-cvslog] avcodec/avpacket: deprecate av_copy_packet_side_data()

[James Almer]

ffmpeg | branch: master | James Almer <jamrial at gmail.com> | Mon Sep 25 17:17:12 2017 -0300| [cf3d2d52b59ddfc2a7c65a8e66f7698c4b837e51] | committer: James Almer

avcodec/avpacket: deprecate av_copy_packet_side_data()

It leaks memory and destroys the dst packet in case of failure, and it
ultimately duplicates functionality already existing in the saner
av_packet_copy_props().

Reviewed-by: wm4
Signed-off-by: James Almer <jamrial at gmail.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=cf3d2d52b59ddfc2a7c65a8e66f7698c4b837e51
---

 libavcodec/avcodec.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index dd7c4b4ce5..52cc5b0ca0 100644
--- a/libavcodec/avcodec.h
+++ b/libavcodec/avcodec.h
@@ -4632,7 +4632,10 @@ int av_copy_packet(AVPacket *dst, const AVPacket *src);
  * Copy packet side data
  *
  * @return 0 on success, negative AVERROR on fail
+ *
+ * @deprecated Use av_packet_copy_props
  */
+attribute_deprecated
 int av_copy_packet_side_data(AVPacket *dst, const AVPacket *src);
 
 /**