[FFmpeg-cvslog] avcodec/nvenc: remove qmin and qmax constraints for vbr
Ganapathy Raman Kasi
git at videolan.org
Wed Mar 1 14:24:34 EET 2017
ffmpeg | branch: master | Ganapathy Raman Kasi <gkasi at nvidia.com> | Fri Feb 24 01:42:27 2017 +0000| [a549243b89da7df5504253b9679b777834014b7f] | committer: Timo Rothenpieler
avcodec/nvenc: remove qmin and qmax constraints for vbr
qmin and qmax are not necessary for nvenc vbr.
Enforcing this constraint, doesn't allow user to use vbr 2 pass mode without explicity setting the qmin and qmax options
Signed-off-by: Timo Rothenpieler <timo at rothenpieler.org>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=a549243b89da7df5504253b9679b777834014b7f
---
libavcodec/nvenc.c | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c
index ba2647b..fbd42f4 100644
--- a/libavcodec/nvenc.c
+++ b/libavcodec/nvenc.c
@@ -589,16 +589,6 @@ static void nvenc_override_rate_control(AVCodecContext *avctx)
}
set_constqp(avctx);
return;
- case NV_ENC_PARAMS_RC_2_PASS_VBR:
- case NV_ENC_PARAMS_RC_VBR:
- if (avctx->qmin < 0 && avctx->qmax < 0) {
- av_log(avctx, AV_LOG_WARNING,
- "The variable bitrate rate-control requires "
- "the 'qmin' and/or 'qmax' option set.\n");
- set_vbr(avctx);
- return;
- }
- /* fall through */
case NV_ENC_PARAMS_RC_VBR_MINQP:
if (avctx->qmin < 0) {
av_log(avctx, AV_LOG_WARNING,
@@ -607,6 +597,9 @@ static void nvenc_override_rate_control(AVCodecContext *avctx)
set_vbr(avctx);
return;
}
+ /* fall through */
+ case NV_ENC_PARAMS_RC_2_PASS_VBR:
+ case NV_ENC_PARAMS_RC_VBR:
set_vbr(avctx);
break;
case NV_ENC_PARAMS_RC_CBR:
More information about the ffmpeg-cvslog
mailing list