[FFmpeg-cvslog] avcodec/wavpack: Check float_shift

Michael Niedermayer git at videolan.org
Sun Jun 18 17:30:58 EEST 2017


ffmpeg | branch: release/3.1 | Michael Niedermayer <michael at niedermayer.cc> | Tue May 30 03:13:21 2017 +0200| [ea70971cbe9ffd23cfd0bf519280a131097f8979] | committer: Michael Niedermayer

avcodec/wavpack: Check float_shift

Fixes: runtime error: shift exponent 40 is too large for 32-bit type 'unsigned int'
Fixes: 1898/clusterfuzz-testcase-minimized-5970744880136192

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
(cherry picked from commit 4020b009d1e88ff10abd25fb768165afa546851d)
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=ea70971cbe9ffd23cfd0bf519280a131097f8979
---

 libavcodec/wavpack.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/libavcodec/wavpack.c b/libavcodec/wavpack.c
index a679d424eb..3bc345e797 100644
--- a/libavcodec/wavpack.c
+++ b/libavcodec/wavpack.c
@@ -872,6 +872,12 @@ static int wavpack_decode_block(AVCodecContext *avctx, int block_no,
             s->float_flag    = bytestream2_get_byte(&gb);
             s->float_shift   = bytestream2_get_byte(&gb);
             s->float_max_exp = bytestream2_get_byte(&gb);
+            if (s->float_shift > 31) {
+                av_log(avctx, AV_LOG_ERROR,
+                       "Invalid FLOATINFO, shift = %d (> 31)\n", s->float_shift);
+                s->float_shift = 0;
+                continue;
+            }
             got_float        = 1;
             bytestream2_skip(&gb, 1);
             break;



More information about the ffmpeg-cvslog mailing list