[FFmpeg-cvslog] avcodec/pnm: Use ff_set_dimensions()
Michael Niedermayer
git at videolan.org
Tue Jun 6 01:08:52 EEST 2017
ffmpeg | branch: release/2.8 | Michael Niedermayer <michael at niedermayer.cc> | Wed May 31 13:39:45 2017 +0200| [9c0c749c334de89d50a6cd706104cf631201dc9b] | committer: Michael Niedermayer
avcodec/pnm: Use ff_set_dimensions()
Fixes: OOM
Fixes: 1906/clusterfuzz-testcase-minimized-4599315114754048
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
(cherry picked from commit a1c0d1d906d27d3f9e1b058bb065f897f90c1c7c)
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=9c0c749c334de89d50a6cd706104cf631201dc9b
---
libavcodec/pnm.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/libavcodec/pnm.c b/libavcodec/pnm.c
index 1675959fbf..8b4a4ac292 100644
--- a/libavcodec/pnm.c
+++ b/libavcodec/pnm.c
@@ -24,6 +24,7 @@
#include "libavutil/imgutils.h"
#include "avcodec.h"
+#include "internal.h"
#include "pnm.h"
static inline int pnm_space(int c)
@@ -61,6 +62,7 @@ int ff_pnm_decode_header(AVCodecContext *avctx, PNMContext * const s)
{
char buf1[32], tuple_type[32];
int h, w, depth, maxval;
+ int ret;
pnm_get(s, buf1, sizeof(buf1));
if(buf1[0] != 'P')
@@ -110,8 +112,9 @@ int ff_pnm_decode_header(AVCodecContext *avctx, PNMContext * const s)
if (w <= 0 || h <= 0 || maxval <= 0 || depth <= 0 || tuple_type[0] == '\0' || av_image_check_size(w, h, 0, avctx) || s->bytestream >= s->bytestream_end)
return AVERROR_INVALIDDATA;
- avctx->width = w;
- avctx->height = h;
+ ret = ff_set_dimensions(avctx, w, h);
+ if (ret < 0)
+ return ret;
s->maxval = maxval;
if (depth == 1) {
if (maxval == 1) {
@@ -153,8 +156,9 @@ int ff_pnm_decode_header(AVCodecContext *avctx, PNMContext * const s)
if(w <= 0 || h <= 0 || av_image_check_size(w, h, 0, avctx) || s->bytestream >= s->bytestream_end)
return AVERROR_INVALIDDATA;
- avctx->width = w;
- avctx->height = h;
+ ret = ff_set_dimensions(avctx, w, h);
+ if (ret < 0)
+ return ret;
if (avctx->pix_fmt != AV_PIX_FMT_MONOWHITE && avctx->pix_fmt != AV_PIX_FMT_MONOBLACK) {
pnm_get(s, buf1, sizeof(buf1));
More information about the ffmpeg-cvslog
mailing list