[FFmpeg-cvslog] opus_pvq: remove unneeded assert

Rostislav Pehlivanov git at videolan.org
Fri Feb 24 09:15:30 EET 2017


ffmpeg | branch: master | Rostislav Pehlivanov <atomnuker at gmail.com> | Fri Feb 24 07:06:59 2017 +0000| [f19442c069929727b19c948619488370d279e177] | committer: Rostislav Pehlivanov

opus_pvq: remove unneeded assert

Since the PVQ search has been well fuzzed and is guaranteed to never
break SUM(abs(y[])) == K, the assert is no longer needed.
Also the assert only prevented coding the wrong vector index but didn't
prevent crashes during searching for it, which made the assert rather
informational than practical.

Signed-off-by: Rostislav Pehlivanov <atomnuker at gmail.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=f19442c069929727b19c948619488370d279e177
---

 libavcodec/opus_pvq.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/libavcodec/opus_pvq.c b/libavcodec/opus_pvq.c
index 0d35367..706e239 100644
--- a/libavcodec/opus_pvq.c
+++ b/libavcodec/opus_pvq.c
@@ -285,7 +285,6 @@ static inline uint32_t celt_icwrsi(uint32_t N, uint32_t K, const int *y)
         idx += CELT_PVQ_U(N - i, sum) + (y[i] < 0)*i_s;
         sum += FFABS(y[i]);
     }
-    av_assert0(sum == K);
     return idx;
 }
 



More information about the ffmpeg-cvslog mailing list