[FFmpeg-cvslog] avfilter/f_setcmd: fix null pointer dereference on using dash as interval

Marton Balint git at videolan.org
Sun Feb 19 17:54:56 EET 2017


ffmpeg | branch: master | Marton Balint <cus at passwd.hu> | Thu Feb  9 00:03:21 2017 +0100| [a9f3e4b138fc14f7512fde821c051fe1ff7f124f] | committer: Marton Balint

avfilter/f_setcmd: fix null pointer dereference on using dash as interval

Fixes Coverity CID 1396259.

Reviewed-by: Paul B Mahol <onemda at gmail.com>
Signed-off-by: Marton Balint <cus at passwd.hu>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=a9f3e4b138fc14f7512fde821c051fe1ff7f124f
---

 libavfilter/f_sendcmd.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/libavfilter/f_sendcmd.c b/libavfilter/f_sendcmd.c
index fb30220..522d6ad 100644
--- a/libavfilter/f_sendcmd.c
+++ b/libavfilter/f_sendcmd.c
@@ -268,6 +268,13 @@ static int parse_interval(Interval *interval, int interval_count,
         char *start, *end;
 
         start = av_strtok(intervalstr, "-", &end);
+        if (!start) {
+            ret = AVERROR(EINVAL);
+            av_log(log_ctx, AV_LOG_ERROR,
+                   "Invalid interval specification '%s' in interval #%d\n",
+                   intervalstr, interval_count);
+            goto end;
+        }
         if ((ret = av_parse_time(&interval->start_ts, start, 1)) < 0) {
             av_log(log_ctx, AV_LOG_ERROR,
                    "Invalid start time specification '%s' in interval #%d\n",



More information about the ffmpeg-cvslog mailing list