[FFmpeg-cvslog] avformat/utils: Check negative bps before shifting in ff_get_pcm_codec_id( )

Chris Cunningham git at videolan.org
Tue May 17 23:49:46 CEST 2016


ffmpeg | branch: master | Chris Cunningham <chcunningham at chromium.org> | Tue May 17 11:28:32 2016 -0700| [2875745d354ab0ebc4af1ebaca5c5a8d26ccdc03] | committer: Michael Niedermayer

avformat/utils: Check negative bps before shifting in ff_get_pcm_codec_id()

Fixes: undefined shift.

Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=2875745d354ab0ebc4af1ebaca5c5a8d26ccdc03
---

 libavformat/utils.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/utils.c b/libavformat/utils.c
index 5f5f03e..d1e4306 100644
--- a/libavformat/utils.c
+++ b/libavformat/utils.c
@@ -2955,7 +2955,7 @@ enum AVCodecID ff_codec_get_id(const AVCodecTag *tags, unsigned int tag)
 
 enum AVCodecID ff_get_pcm_codec_id(int bps, int flt, int be, int sflags)
 {
-    if (bps > 64U)
+    if (bps <= 0 || bps > 64)
         return AV_CODEC_ID_NONE;
 
     if (flt) {



More information about the ffmpeg-cvslog mailing list