[FFmpeg-cvslog] [FFmpeg-devel] avcodec/aac_tablegen: speed up table initialization

[Clément Bœsch]

On Fri, Nov 27, 2015 at 10:09:32AM -0500, Ganesh Ajjanagadde wrote:
> On Fri, Nov 27, 2015 at 9:37 AM, Clément Bœsch <u at pkh.me> wrote:
> > On Fri, Nov 27, 2015 at 12:40:27PM +0100, Ganesh Ajjanagadde wrote:
> > [...]
> >> diff --git a/libavcodec/aac_tablegen.h b/libavcodec/aac_tablegen.h
> >> index 8b223f9..85e189d 100644
> >> --- a/libavcodec/aac_tablegen.h
> >> +++ b/libavcodec/aac_tablegen.h
> >> @@ -35,9 +35,46 @@ float ff_aac_pow34sf_tab[428];
> >>  av_cold void ff_aac_tableinit(void)
> >>  {
> >>      int i;
> >> +
> >> +    /* 2^(i/16) for 0 <= i <= 15 */
> >> +    const float exp2_lut[] = {
> >
> > sorry to notice only now; maybe add a static?
> 
> No problem, since it does not really matter much. Will push later today.
> 

It does a bit: http://b.pkh.me/nostatic-static.html

A quick lookup at the diff tells me the static prevents a copy on the
stack.

BTW, if someone knows a better way of diffing asm, I'm all ear. funman on
irc seemed to suggest the existence of objdump beautifiers, but i couldn't
find anything relevant.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20151127/4ef72476/attachment.sig>