[FFmpeg-cvslog] avcodec/utils: Better check for channels in av_get_audio_frame_duration()
Michael Niedermayer
git at videolan.org
Thu Nov 26 17:55:02 CET 2015
ffmpeg | branch: release/2.5 | Michael Niedermayer <michael at niedermayer.cc> | Sat Nov 14 01:35:08 2015 +0100| [72ac69bd05ef65221473766b62756749fb4f4456] | committer: Michael Niedermayer
avcodec/utils: Better check for channels in av_get_audio_frame_duration()
Fixes integer overflow
Fixes: 0c2625f236ced104d402b4a03c0d65c7/asan_generic_274e1ce_5990_9314e7a67c26aecf011b178ade9f217c.avi
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
(cherry picked from commit 4e16ad2868a1819de6680fc355a8eb20164adaea)
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=72ac69bd05ef65221473766b62756749fb4f4456
---
libavcodec/utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/utils.c b/libavcodec/utils.c
index 0cc1f90..ad61ac3 100644
--- a/libavcodec/utils.c
+++ b/libavcodec/utils.c
@@ -3371,7 +3371,7 @@ int av_get_audio_frame_duration(AVCodecContext *avctx, int frame_bytes)
return frame_bytes * 8 / bps;
}
- if (ch > 0) {
+ if (ch > 0 && ch < INT_MAX/16) {
/* calc from frame_bytes and channels */
switch (id) {
case AV_CODEC_ID_ADPCM_AFC:
More information about the ffmpeg-cvslog
mailing list