[FFmpeg-cvslog] error_resilience: do not require mbintra/skip tables

Anton Khirnov git at videolan.org
Sat Mar 21 19:36:05 CET 2015


ffmpeg | branch: master | Anton Khirnov <anton at khirnov.net> | Wed Jan 28 12:38:57 2015 +0100| [5bc69f38c1af71fbcbfb4b5efa77d0aeb5424c04] | committer: Anton Khirnov

error_resilience: do not require mbintra/skip tables

h264dec does not use them at all and only allocates them for ER.

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=5bc69f38c1af71fbcbfb4b5efa77d0aeb5424c04
---

 libavcodec/error_resilience.c |    7 ++++---
 libavcodec/h264.c             |    7 -------
 2 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/libavcodec/error_resilience.c b/libavcodec/error_resilience.c
index 0120109..2c7836f 100644
--- a/libavcodec/error_resilience.c
+++ b/libavcodec/error_resilience.c
@@ -934,7 +934,7 @@ void ff_er_frame_end(ERContext *s)
             const int mb_xy = s->mb_index2xy[i];
             int       error = s->error_status_table[mb_xy];
 
-            if (!s->mbskip_table[mb_xy]) // FIXME partition specific
+            if (s->mbskip_table && !s->mbskip_table[mb_xy]) // FIXME partition specific
                 distance++;
             if (error & (1 << error_type))
                 distance = 0;
@@ -1205,11 +1205,12 @@ ec_clean:
         const int mb_xy = s->mb_index2xy[i];
         int       error = s->error_status_table[mb_xy];
 
-        if (s->cur_pic.f->pict_type != AV_PICTURE_TYPE_B &&
+        if (s->mbskip_table && s->cur_pic.f->pict_type != AV_PICTURE_TYPE_B &&
             (error & (ER_DC_ERROR | ER_MV_ERROR | ER_AC_ERROR))) {
             s->mbskip_table[mb_xy] = 0;
         }
-        s->mbintra_table[mb_xy] = 1;
+        if (s->mbintra_table)
+            s->mbintra_table[mb_xy] = 1;
     }
 
     memset(&s->cur_pic, 0, sizeof(ERPicture));
diff --git a/libavcodec/h264.c b/libavcodec/h264.c
index b711c64..007ba2a 100644
--- a/libavcodec/h264.c
+++ b/libavcodec/h264.c
@@ -383,8 +383,6 @@ void ff_h264_free_tables(H264Context *h, int free_rbsp)
         av_freep(&hx->er.mb_index2xy);
         av_freep(&hx->er.error_status_table);
         av_freep(&hx->er.er_temp_buffer);
-        av_freep(&hx->er.mbintra_table);
-        av_freep(&hx->er.mbskip_table);
 
         if (free_rbsp) {
             av_freep(&hx->rbsp_buffer);
@@ -524,11 +522,6 @@ int ff_h264_context_init(H264Context *h)
         FF_ALLOCZ_OR_GOTO(h->avctx, er->error_status_table,
                           mb_array_size * sizeof(uint8_t), fail);
 
-        FF_ALLOC_OR_GOTO(h->avctx, er->mbintra_table, mb_array_size, fail);
-        memset(er->mbintra_table, 1, mb_array_size);
-
-        FF_ALLOCZ_OR_GOTO(h->avctx, er->mbskip_table, mb_array_size + 2, fail);
-
         FF_ALLOC_OR_GOTO(h->avctx, er->er_temp_buffer,
                          h->mb_height * h->mb_stride, fail);
 



More information about the ffmpeg-cvslog mailing list