[FFmpeg-cvslog] avcodec/tiff: move bpp check to after "end:"
Michael Niedermayer
git at videolan.org
Sun Mar 8 23:37:52 CET 2015
ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Sun Mar 8 23:27:43 2015 +0100| [d5e9fc782150d4596c72440a0aa02b7f4f1254b1] | committer: Michael Niedermayer
avcodec/tiff: move bpp check to after "end:"
This ensures that all current and future code-pathes get bpp checked
Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=d5e9fc782150d4596c72440a0aa02b7f4f1254b1
---
libavcodec/tiff.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c
index fe45cac..7a7f9b7 100644
--- a/libavcodec/tiff.c
+++ b/libavcodec/tiff.c
@@ -847,13 +847,6 @@ static int tiff_decode_tag(TiffContext *s, AVFrame *frame)
s->bpp = -1;
}
}
- if (s->bpp > 64U) {
- av_log(s->avctx, AV_LOG_ERROR,
- "This format is not supported (bpp=%d, %d components)\n",
- s->bpp, count);
- s->bpp = 0;
- return AVERROR_INVALIDDATA;
- }
break;
case TIFF_SAMPLES_PER_PIXEL:
if (count != 1) {
@@ -1166,6 +1159,13 @@ static int tiff_decode_tag(TiffContext *s, AVFrame *frame)
}
}
end:
+ if (s->bpp > 64U) {
+ av_log(s->avctx, AV_LOG_ERROR,
+ "This format is not supported (bpp=%d, %d components)\n",
+ s->bpp, count);
+ s->bpp = 0;
+ return AVERROR_INVALIDDATA;
+ }
bytestream2_seek(&s->gb, start, SEEK_SET);
return 0;
}
More information about the ffmpeg-cvslog
mailing list