[FFmpeg-cvslog] lavfi/boxblur: Readd 8bit colour spaces on big-endian.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Fri Jan 9 09:27:40 CET 2015


On 08.01.2015, at 17:05, git at videolan.org (Carl Eugen Hoyos) wrote:
> ffmpeg | branch: master | Carl Eugen Hoyos <cehoyos at ag.or.at> | Thu Jan  8 15:24:59 2015 +0100| [26ac6d543598f17ceb6771bce08a00291e62a4ef] | committer: Carl Eugen Hoyos
> 
> lavfi/boxblur: Readd 8bit colour spaces on big-endian.
> 
>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=26ac6d543598f17ceb6771bce08a00291e62a4ef
> ---
> 
> libavfilter/vf_boxblur.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavfilter/vf_boxblur.c b/libavfilter/vf_boxblur.c
> index 89cf015..3ccf268 100644
> --- a/libavfilter/vf_boxblur.c
> +++ b/libavfilter/vf_boxblur.c
> @@ -124,7 +124,7 @@ static int query_formats(AVFilterContext *ctx)
>         const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(fmt);
>         if (!(desc->flags & (AV_PIX_FMT_FLAG_HWACCEL | AV_PIX_FMT_FLAG_BITSTREAM | AV_PIX_FMT_FLAG_PAL)) &&
>             (desc->flags & AV_PIX_FMT_FLAG_PLANAR || desc->nb_components == 1) &&
> -            !(desc->flags & AV_PIX_FMT_FLAG_BE) == !HAVE_BIGENDIAN)
> +            (!(desc->flags & AV_PIX_FMT_FLAG_BE) == !HAVE_BIGENDIAN) || desc->comp[0].depth_minus1 == 7)

That doesn't seem quite right if there's more than one component, at some point we might add a format that has 8 bit for the first and more bits for some other component.
Maybe adding a common function that checks for native-endian would make it easier to understand, too.


More information about the ffmpeg-cvslog mailing list