[FFmpeg-cvslog] mmvideo: check frame dimensions
Anton Khirnov
git at videolan.org
Tue Jan 6 19:35:33 CET 2015
ffmpeg | branch: release/2.3 | Anton Khirnov <anton at khirnov.net> | Sun Dec 14 21:01:59 2014 +0100| [8a01fb3729e58aab2fdc17ed6ddfa2c4efb3a54c] | committer: Michael Niedermayer
mmvideo: check frame dimensions
The frame size must be set by the caller and each dimension must be a
multiple of 2.
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
See: 8b0e96e1f21b761ca15dbb470cd619a1ebf86c3e
These should be redundant, but are backported for saftey anyway
(cherry picked from commit b0273232d8fffdc8a977ccdad460b8071a0e353c)
Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=8a01fb3729e58aab2fdc17ed6ddfa2c4efb3a54c
---
libavcodec/mmvideo.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/libavcodec/mmvideo.c b/libavcodec/mmvideo.c
index baedccd..9af35e5 100644
--- a/libavcodec/mmvideo.c
+++ b/libavcodec/mmvideo.c
@@ -61,6 +61,13 @@ static av_cold int mm_decode_init(AVCodecContext *avctx)
avctx->pix_fmt = AV_PIX_FMT_PAL8;
+ if (!avctx->width || !avctx->height ||
+ (avctx->width & 1) || (avctx->height & 1)) {
+ av_log(avctx, AV_LOG_ERROR, "Invalid video dimensions: %dx%d\n",
+ avctx->width, avctx->height);
+ return AVERROR(EINVAL);
+ }
+
s->frame = av_frame_alloc();
if (!s->frame)
return AVERROR(ENOMEM);
More information about the ffmpeg-cvslog
mailing list