[FFmpeg-cvslog] avcodec/snow: Free all planes and bands independent of the last count

Michael Niedermayer git at videolan.org
Tue Feb 24 03:31:12 CET 2015


ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Tue Feb 24 03:21:12 2015 +0100| [721c916dd55b52935140b602a679739ce098760a] | committer: Michael Niedermayer

avcodec/snow: Free all planes and bands independent of the last count

Fixes memleak
Fixes: signal_sigsegv_24169e6_3445_cov_3778346427_snow_chroma_bug.avi

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni at gmx.at>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=721c916dd55b52935140b602a679739ce098760a
---

 libavcodec/snow.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavcodec/snow.c b/libavcodec/snow.c
index c4f7004..07ad854 100644
--- a/libavcodec/snow.c
+++ b/libavcodec/snow.c
@@ -718,8 +718,8 @@ av_cold void ff_snow_common_end(SnowContext *s)
         av_frame_free(&s->last_picture[i]);
     }
 
-    for(plane_index=0; plane_index < s->nb_planes; plane_index++){
-        for(level=s->spatial_decomposition_count-1; level>=0; level--){
+    for(plane_index=0; plane_index < MAX_PLANES; plane_index++){
+        for(level=MAX_DECOMPOSITIONS-1; level>=0; level--){
             for(orientation=level ? 1 : 0; orientation<4; orientation++){
                 SubBand *b= &s->plane[plane_index].band[level][orientation];
 



More information about the ffmpeg-cvslog mailing list