[FFmpeg-cvslog] avfilter/hqdn3d: an invalid bit depth means a bug, not invalid read data

Clément Bœsch git at videolan.org
Sun Feb 8 17:22:45 CET 2015


ffmpeg | branch: master | Clément Bœsch <u at pkh.me> | Sun Feb  8 17:16:21 2015 +0100| [55feff57cec85cfcc972d40e02af131f0cb86a34] | committer: Clément Bœsch

avfilter/hqdn3d: an invalid bit depth means a bug, not invalid read data

This code looks clumsy, and an assert would probably be more welcome.

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=55feff57cec85cfcc972d40e02af131f0cb86a34
---

 libavfilter/vf_hqdn3d.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavfilter/vf_hqdn3d.c b/libavfilter/vf_hqdn3d.c
index 4b1f2f9..99d22d9 100644
--- a/libavfilter/vf_hqdn3d.c
+++ b/libavfilter/vf_hqdn3d.c
@@ -155,7 +155,7 @@ static int denoise_depth(HQDN3DContext *s,
 
 #define denoise(...)                                                          \
     do {                                                                      \
-        int ret = AVERROR_INVALIDDATA;                                        \
+        int ret = AVERROR_BUG;                                                \
         switch (s->depth) {                                                   \
             case  8: ret = denoise_depth(__VA_ARGS__,  8); break;             \
             case  9: ret = denoise_depth(__VA_ARGS__,  9); break;             \



More information about the ffmpeg-cvslog mailing list