[FFmpeg-cvslog] xcbgrab: XCB-based screen capture

compn tempn at mi.rr.com
Tue Oct 28 15:54:25 CET 2014


On Tue, 28 Oct 2014 10:05:29 +0100
Nicolas George <george at nsup.org> wrote:

> Le sextidi 6 brumaire, an CCXXIII, compn a écrit :
> > from x11grab.c:
> > 
> > AV_OPT_TYPE_INT, {.i64 = 1}, 0, 1, DEC }, { "follow_mouse", "move
> > the grabbing region when the mouse pointer reaches within specified
> > amount of pixels to the edge of region", OFFSET(follow_mouse),

from xcbgrab.c:
+    { "follow_mouse", "Move the grabbing region when the mouse
pointer reaches within specified amount of pixels to the edge of
region.",

> Or is it just related to your next point?

yes

> 
> > is this file based on x11grab.c ? if so , copyrights need to be
> > modified.
> 
> Regarding the code itself, my understanding reading Luca's
> messages is that it is a new implementation. Of course, the parts
> that are far from the back-end library and straightforward are bound
> to look similar.

the message of follow_mouse is a direct copy (with a punctuation fix).

my question is, if its a copy/paste of the option description, do we
have to put some original author attribution into the copyright list at
the top of xcbgrab.c ? 

-compn


More information about the ffmpeg-cvslog mailing list