[FFmpeg-cvslog] avcodec/nellymoserenc: fix sign error

[Michael Niedermayer]

On Fri, Nov 14, 2014 at 07:52:45PM +0100, Reimar Döffinger wrote:
> On Thu, Nov 13, 2014 at 09:13:23PM +0100, Michael Niedermayer wrote:
> > ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Thu Nov 13 20:40:37 2014 +0100| [5c805d69a49a1f32a7a8a1b16fb3d631d85ca56d] | committer: Michael Niedermayer
> > 
> > avcodec/nellymoserenc: fix sign error
> > 
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > 
> > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=5c805d69a49a1f32a7a8a1b16fb3d631d85ca56d
> > ---
> > 
> >  libavcodec/nellymoserenc.c |    2 +-
> >  tests/fate/audio.mak       |    4 ++--
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/libavcodec/nellymoserenc.c b/libavcodec/nellymoserenc.c
> > index 9bbdd52..78f1092 100644
> > --- a/libavcodec/nellymoserenc.c
> > +++ b/libavcodec/nellymoserenc.c
> > @@ -175,7 +175,7 @@ static av_cold int encode_init(AVCodecContext *avctx)
> >      /* Generate overlap window */
> >      ff_init_ff_sine_windows(7);
> >      for (i = 0; i < POW_TABLE_SIZE; i++)
> > -        pow_table[i] = -pow(2, -i / 2048.0 - 3.0 + POW_TABLE_OFFSET);
> > +        pow_table[i] = pow(2, -i / 2048.0 - 3.0 + POW_TABLE_OFFSET);
> 
> Hm, I think you should then also change this line:
> static float pow_table[POW_TABLE_SIZE];     ///< -pow(2, -i / 2048.0 - 3.0);

done


> (note that I have no clue which would be right and why, though the
> fate test seems to agree it is better)
> _______________________________________________
> ffmpeg-cvslog mailing list
> ffmpeg-cvslog at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-cvslog
> 

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20141116/a56d8374/attachment.asc>