[FFmpeg-cvslog] avfilter/avf_showwaves: fix off by one error in loop condition

Marton Balint git at videolan.org
Sun Nov 9 16:50:03 CET 2014


ffmpeg | branch: master | Marton Balint <cus at passwd.hu> | Sun Nov  9 14:19:36 2014 +0100| [86476c510ebd14d33ed02289d71bae874f8707a4] | committer: Michael Niedermayer

avfilter/avf_showwaves: fix off by one error in loop condition

It caused segfaults.

Signed-off-by: Marton Balint <cus at passwd.hu>
Reviewed-by: Paul B Mahol <onemda at gmail.com>
Signed-off-by: Michael Niedermayer <michaelni at gmx.at>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=86476c510ebd14d33ed02289d71bae874f8707a4
---

 libavfilter/avf_showwaves.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavfilter/avf_showwaves.c b/libavfilter/avf_showwaves.c
index 4cd225a..fa34a52 100644
--- a/libavfilter/avf_showwaves.c
+++ b/libavfilter/avf_showwaves.c
@@ -157,7 +157,7 @@ inline static int push_frame(AVFilterLink *outlink)
         showwaves->req_fullfilled = 1;
     showwaves->outpicref = NULL;
     showwaves->buf_idx = 0;
-    for (i = 0; i <= nb_channels; i++)
+    for (i = 0; i < nb_channels; i++)
         showwaves->buf_idy[i] = 0;
     return ret;
 }



More information about the ffmpeg-cvslog mailing list