[FFmpeg-cvslog] h264: check that an IDR NAL only contains I slices

Anton Khirnov git at videolan.org
Sat Jan 18 23:19:55 CET 2014


ffmpeg | branch: master | Anton Khirnov <anton at khirnov.net> | Thu Nov 28 10:54:35 2013 +0100| [8b2e5e42bb9d6a59ede5af2e6df4aaf7750d1195] | committer: Anton Khirnov

h264: check that an IDR NAL only contains I slices

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC:libav-stable at libav.org

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=8b2e5e42bb9d6a59ede5af2e6df4aaf7750d1195
---

 libavcodec/h264.c |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/libavcodec/h264.c b/libavcodec/h264.c
index 6f329aa..4b10a68 100644
--- a/libavcodec/h264.c
+++ b/libavcodec/h264.c
@@ -3383,6 +3383,12 @@ static int decode_slice_header(H264Context *h, H264Context *h0)
     h->slice_type     = slice_type;
     h->slice_type_nos = slice_type & 3;
 
+    if (h->nal_unit_type  == NAL_IDR_SLICE &&
+        h->slice_type_nos != AV_PICTURE_TYPE_I) {
+        av_log(h->avctx, AV_LOG_ERROR, "A non-intra slice in an IDR NAL unit.\n");
+        return AVERROR_INVALIDDATA;
+    }
+
     // to make a few old functions happy, it's wrong though
     h->pict_type = h->slice_type;
 



More information about the ffmpeg-cvslog mailing list