[FFmpeg-cvslog] mpegvideo: Drop a faulty assert

Luca Barbato git at videolan.org
Sun Jan 12 16:13:02 CET 2014


ffmpeg | branch: release/1.1 | Luca Barbato <lu_zero at gentoo.org> | Tue Oct 22 19:17:10 2013 +0200| [0e8ae6d10c609bb968c141aa2436413a55852590] | committer: Reinhard Tartler

mpegvideo: Drop a faulty assert

That check is easily reachable by faulty input.

CC:libav-stable at libav.org
Reported-by: Torsten Sadowski <tsadowski at gmx.net>
(cherry picked from commit 72072bf9de3241848ea86f68d2297b7a5d6ad49b)
Signed-off-by: Reinhard Tartler <siretart at tauware.de>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=0e8ae6d10c609bb968c141aa2436413a55852590
---

 libavcodec/mpegvideo.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c
index 2f65779..eb71670 100644
--- a/libavcodec/mpegvideo.c
+++ b/libavcodec/mpegvideo.c
@@ -1521,8 +1521,12 @@ int ff_MPV_frame_start(MpegEncContext *s, AVCodecContext *avctx)
             s->last_picture_ptr->owner2 = s;
     }
 
-    assert(s->pict_type == AV_PICTURE_TYPE_I || (s->last_picture_ptr &&
-                                                 s->last_picture_ptr->f.data[0]));
+    if (s->pict_type != AV_PICTURE_TYPE_I &&
+        !(s->last_picture_ptr && s->last_picture_ptr->f.data[0])) {
+        av_log(s, AV_LOG_ERROR,
+               "Non-reference picture received and no reference available\n");
+        return AVERROR_INVALIDDATA;
+    }
 
     if (s->picture_structure!= PICT_FRAME && s->out_format != FMT_H264) {
         int i;



More information about the ffmpeg-cvslog mailing list