[FFmpeg-cvslog] dcadsp: scan coefficients linearly in dca_lfe_fir

Christophe Gisquet git at videolan.org
Fri Feb 28 20:04:47 CET 2014


ffmpeg | branch: master | Christophe Gisquet <christophe.gisquet at gmail.com> | Fri Feb 14 15:03:08 2014 +0000| [57b1eb9f75b04571063ddec316e290c216c114ac] | committer: Janne Grunau

dcadsp: scan coefficients linearly in dca_lfe_fir

This change is inspired by x86 asm where it frees a register.

Signed-off-by: Janne Grunau <janne-libav at jannau.net>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=57b1eb9f75b04571063ddec316e290c216c114ac
---

 libavcodec/dcadsp.c |   14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/libavcodec/dcadsp.c b/libavcodec/dcadsp.c
index 8fc49ce..294a1b2 100644
--- a/libavcodec/dcadsp.c
+++ b/libavcodec/dcadsp.c
@@ -36,22 +36,20 @@ static inline void
 dca_lfe_fir(float *out, const float *in, const float *coefs,
             int decifactor)
 {
-    float *out2 = out + decifactor;
-    const float *cf0 = coefs;
-    const float *cf1 = coefs + 256;
+    float *out2    = out + 2 * decifactor - 1;
+    int num_coeffs = 256 / decifactor;
     int j, k;
 
     /* One decimated sample generates 2*decifactor interpolated ones */
     for (k = 0; k < decifactor; k++) {
         float v0 = 0.0;
         float v1 = 0.0;
-        for (j = 0; j < 256 / decifactor; j++) {
-            float s = in[-j];
-            v0 += s * *cf0++;
-            v1 += s * *--cf1;
+        for (j = 0; j < num_coeffs; j++, coefs++) {
+            v0 += in[-j] * *coefs;
+            v1 += in[j + 1 - num_coeffs] * *coefs;
         }
         *out++  = v0;
-        *out2++ = v1;
+        *out2-- = v1;
     }
 }
 



More information about the ffmpeg-cvslog mailing list