[FFmpeg-cvslog] avcodec/vmdvideo: Check len before using it in method 3
Michael Niedermayer
git at videolan.org
Sun Dec 21 04:50:34 CET 2014
ffmpeg | branch: release/1.1 | Michael Niedermayer <michaelni at gmx.at> | Tue Dec 16 16:24:55 2014 +0100| [24fefa73dba44d07b4cef8b6243cfa37f6ec3e54] | committer: Michael Niedermayer
avcodec/vmdvideo: Check len before using it in method 3
Fixes out of array access
Fixes: asan_heap-oob_4d23ba_91_cov_3853393937_128.vmd
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
(cherry picked from commit 3030fb7e0d41836f8add6399e9a7c7b740b48bfd)
Conflicts:
libavcodec/vmdav.c
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=24fefa73dba44d07b4cef8b6243cfa37f6ec3e54
---
libavcodec/vmdav.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/libavcodec/vmdav.c b/libavcodec/vmdav.c
index 9c24a01..f17bd49 100644
--- a/libavcodec/vmdav.c
+++ b/libavcodec/vmdav.c
@@ -340,8 +340,12 @@ static int vmd_decode(VmdVideoContext *s)
len = rle_unpack(gb.buffer, &dp[ofs],
len, bytestream2_get_bytes_left(&gb),
frame_width - ofs);
- else
+ else {
+ if (ofs + len > frame_width ||
+ bytestream2_get_bytes_left(&gb) < len)
+ return AVERROR_INVALIDDATA;
bytestream2_get_buffer(&gb, &dp[ofs], len);
+ }
bytestream2_skip(&gb, len);
} else {
/* interframe pixel copy */
More information about the ffmpeg-cvslog
mailing list