[FFmpeg-cvslog] huffyuvdec: check width size for yuv422p

Michael Niedermayer git at videolan.org
Mon Aug 11 18:35:02 CEST 2014


ffmpeg | branch: release/2.2 | Michael Niedermayer <michaelni at gmx.at> | Sun Aug  3 00:54:33 2014 +0100| [aa943bd31fada23db5cb9611215656ab9ebe5b94] | committer: Anton Khirnov

huffyuvdec: check width size for yuv422p

Avoid out of array accesses.

CC: libav-stable at libav.org
Bug-Id: CVE-2013-0848
Signed-off-by: Vittorio Giovara <vittorio.giovara at gmail.com>
Signed-off-by: Anton Khirnov <anton at khirnov.net>
(cherry picked from commit a7153444df9040bf6ae103e0bbf6104b66f974cb)
Signed-off-by: Anton Khirnov <anton at khirnov.net>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=aa943bd31fada23db5cb9611215656ab9ebe5b94
---

 libavcodec/huffyuvdec.c |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/libavcodec/huffyuvdec.c b/libavcodec/huffyuvdec.c
index 016b0d6..1308bba 100644
--- a/libavcodec/huffyuvdec.c
+++ b/libavcodec/huffyuvdec.c
@@ -339,6 +339,13 @@ static av_cold int decode_init(AVCodecContext *avctx)
         return AVERROR_INVALIDDATA;
     }
 
+    if (s->predictor == MEDIAN && avctx->pix_fmt == AV_PIX_FMT_YUV422P &&
+        avctx->width % 4) {
+        av_log(avctx, AV_LOG_ERROR, "width must be multiple of 4 "
+               "for this combination of colorspace and predictor type.\n");
+        return AVERROR_INVALIDDATA;
+    }
+
     if ((ret = ff_huffyuv_alloc_temp(s)) < 0)
         return ret;
 



More information about the ffmpeg-cvslog mailing list