[FFmpeg-cvslog] ffserver: do not ignore lseek() return

Reynaldo H. Verdejo Pinochet git at videolan.org
Tue Apr 29 07:12:13 CEST 2014


ffmpeg | branch: master | Reynaldo H. Verdejo Pinochet <r.verdejo at sisa.samsung.com> | Mon Apr 28 23:48:36 2014 -0400| [5b881499a8e40ad0aa3424ec4d9adeb8008c4189] | committer: Reynaldo H. Verdejo Pinochet

ffserver: do not ignore lseek() return

Should fix FFmpeg Coverity Scan issue #732177

Signed-off-by: Reynaldo H. Verdejo Pinochet <r.verdejo at sisa.samsung.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=5b881499a8e40ad0aa3424ec4d9adeb8008c4189
---

 ffserver.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/ffserver.c b/ffserver.c
index 589ba5f..9104984 100644
--- a/ffserver.c
+++ b/ffserver.c
@@ -2755,8 +2755,11 @@ static int http_receive_data(HTTPContext *c)
         /* a packet has been received : write it in the store, except
            if header */
         if (c->data_count > FFM_PACKET_SIZE) {
-            /* XXX: use llseek or url_seek */
-            lseek(c->feed_fd, feed->feed_write_index, SEEK_SET);
+            /* XXX: use llseek or url_seek
+             * XXX: Should probably fail? */
+            if (lseek(c->feed_fd, feed->feed_write_index, SEEK_SET) == -1)
+                http_log("Seek to %"PRId64" failed\n", feed->feed_write_index);
+
             if (write(c->feed_fd, c->buffer, FFM_PACKET_SIZE) < 0) {
                 http_log("Error writing to feed file: %s\n", strerror(errno));
                 goto fail;



More information about the ffmpeg-cvslog mailing list