[FFmpeg-cvslog] af_channelmap: sanity check input channel indices in all cases.
Anton Khirnov
git at videolan.org
Sun May 12 13:41:56 CEST 2013
ffmpeg | branch: release/1.1 | Anton Khirnov <anton at khirnov.net> | Sun Apr 14 12:07:24 2013 +0200| [8f558c3e101859aec9adcb4b4b270ae1ef8f88b5] | committer: Reinhard Tartler
af_channelmap: sanity check input channel indices in all cases.
Fixes invalid reads from non-existing channels.
CC:libav-stable at libav.org
(cherry picked from commit aafed1175df76603e94c99a7748968780d6548d2)
Signed-off-by: Reinhard Tartler <siretart at tauware.de>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=8f558c3e101859aec9adcb4b4b270ae1ef8f88b5
---
libavfilter/af_channelmap.c | 21 +++++++++++++++------
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/libavfilter/af_channelmap.c b/libavfilter/af_channelmap.c
index 8b72d5b..c4b87da 100644
--- a/libavfilter/af_channelmap.c
+++ b/libavfilter/af_channelmap.c
@@ -362,23 +362,32 @@ static int channelmap_config_input(AVFilterLink *inlink)
{
AVFilterContext *ctx = inlink->dst;
ChannelMapContext *s = ctx->priv;
+ int nb_channels = av_get_channel_layout_nb_channels(inlink->channel_layout);
int i, err = 0;
const char *channel_name;
char layout_name[256];
- if (s->mode == MAP_PAIR_STR_INT || s->mode == MAP_PAIR_STR_STR) {
- for (i = 0; i < s->nch; i++) {
+ for (i = 0; i < s->nch; i++) {
+ if (s->mode == MAP_PAIR_STR_INT || s->mode == MAP_PAIR_STR_STR) {
s->map[i].in_channel_idx = av_get_channel_layout_channel_index(
inlink->channel_layout, s->map[i].in_channel);
- if (s->map[i].in_channel_idx < 0) {
+ }
+
+ if (s->map[i].in_channel_idx < 0 ||
+ s->map[i].in_channel_idx >= nb_channels) {
+ av_get_channel_layout_string(layout_name, sizeof(layout_name),
+ 0, inlink->channel_layout);
+ if (s->map[i].in_channel) {
channel_name = av_get_channel_name(s->map[i].in_channel);
- av_get_channel_layout_string(layout_name, sizeof(layout_name),
- 0, inlink->channel_layout);
av_log(ctx, AV_LOG_ERROR,
"input channel '%s' not available from input layout '%s'\n",
channel_name, layout_name);
- err = AVERROR(EINVAL);
+ } else {
+ av_log(ctx, AV_LOG_ERROR,
+ "input channel #%d not available from input layout '%s'\n",
+ s->map[i].in_channel_idx, layout_name);
}
+ err = AVERROR(EINVAL);
}
}
More information about the ffmpeg-cvslog
mailing list