[FFmpeg-cvslog] h264: check mb_width/height
Michael Niedermayer
git at videolan.org
Mon May 6 02:24:25 CEST 2013
ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Mon May 6 01:37:34 2013 +0200| [5a9e3760495e8678ae87314670e3d9d5a1792c8d] | committer: Michael Niedermayer
h264: check mb_width/height
Fixes inconsistency that leads to out of array accesses with threads
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=5a9e3760495e8678ae87314670e3d9d5a1792c8d
---
libavcodec/h264.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libavcodec/h264.c b/libavcodec/h264.c
index d4a6c6a..3d3746f 100644
--- a/libavcodec/h264.c
+++ b/libavcodec/h264.c
@@ -3310,7 +3310,10 @@ static int decode_slice_header(H264Context *h, H264Context *h0)
|| 16*h->sps.mb_height * (2 - h->sps.frame_mbs_only_flag) != h->avctx->coded_height
|| h->avctx->bits_per_raw_sample != h->sps.bit_depth_luma
|| h->cur_chroma_format_idc != h->sps.chroma_format_idc
- || av_cmp_q(h->sps.sar, h->avctx->sample_aspect_ratio)));
+ || av_cmp_q(h->sps.sar, h->avctx->sample_aspect_ratio)
+ || h->mb_width != h->sps.mb_width
+ || h->mb_height != h->sps.mb_height * (2 - h->sps.frame_mbs_only_flag)
+ ));
if (h0->avctx->pix_fmt != get_pixel_format(h0, 0))
must_reinit = 1;
More information about the ffmpeg-cvslog
mailing list