[FFmpeg-cvslog] lavc/libtheoraenc: clarify comment about global_quality to quality conversion

Stefano Sabatini git at videolan.org
Sat Mar 30 16:59:21 CET 2013


ffmpeg | branch: master | Stefano Sabatini <stefasab at gmail.com> | Tue Mar 19 13:19:12 2013 +0100| [37fce84e2718631e1d6a5ead16510df591d43151] | committer: Stefano Sabatini

lavc/libtheoraenc: clarify comment about global_quality to quality conversion

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=37fce84e2718631e1d6a5ead16510df591d43151
---

 libavcodec/libtheoraenc.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/libavcodec/libtheoraenc.c b/libavcodec/libtheoraenc.c
index 893370f..a2e5b74 100644
--- a/libavcodec/libtheoraenc.c
+++ b/libavcodec/libtheoraenc.c
@@ -207,11 +207,11 @@ static av_cold int encode_init(AVCodecContext* avc_context)
     avcodec_get_chroma_sub_sample(avc_context->pix_fmt, &h->uv_hshift, &h->uv_vshift);
 
     if (avc_context->flags & CODEC_FLAG_QSCALE) {
-        /* to be constant with the libvorbis implementation, clip global_quality to 0 - 10
-           Theora accepts a quality parameter p, which is:
-                * 0 <= p <=63
-                * an int value
-         */
+        /* Clip global_quality in QP units to the [0 - 10] range
+           to be consistent with the libvorbis implementation.
+           Theora accepts a quality parameter which is an int value in
+           the [0 - 63] range.
+        */
         t_info.quality        = av_clipf(avc_context->global_quality / (float)FF_QP2LAMBDA, 0, 10) * 6.3;
         t_info.target_bitrate = 0;
     } else {



More information about the ffmpeg-cvslog mailing list