[FFmpeg-cvslog] sanm: add forgotten check for decoded_size in old_codec37()

Michael Niedermayer git at videolan.org
Sun Mar 3 03:35:49 CET 2013


ffmpeg | branch: release/1.0 | Michael Niedermayer <michaelni at gmx.at> | Tue Feb 12 01:09:03 2013 +0100| [4f873341b4d522b1bfa385a1f6fc86bb8b6dc879] | committer: Michael Niedermayer

sanm: add forgotten check for decoded_size in old_codec37()

Fixes out of array accesses

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
(cherry picked from commit 365270aec5c2b9284230abc702b11168818f14cf)

Signed-off-by: Michael Niedermayer <michaelni at gmx.at>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=4f873341b4d522b1bfa385a1f6fc86bb8b6dc879
---

 libavcodec/sanm.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/libavcodec/sanm.c b/libavcodec/sanm.c
index 21073e2..1d5d064 100644
--- a/libavcodec/sanm.c
+++ b/libavcodec/sanm.c
@@ -415,6 +415,11 @@ static int old_codec37(SANMVideoContext *ctx, int top,
     flags        = bytestream2_get_byte(&ctx->gb);
     bytestream2_skip(&ctx->gb, 3);
 
+    if (decoded_size > height * stride - left - top * stride) {
+        decoded_size = height * stride - left - top * stride;
+        av_log(ctx->avctx, AV_LOG_WARNING, "decoded size is too large\n");
+    }
+
     ctx->rotate_code = 0;
 
     if (((seq & 1) || !(flags & 1)) && (compr && compr != 2))



More information about the ffmpeg-cvslog mailing list