[FFmpeg-cvslog] sgidec: use unchecked bytestream2 functions where it makes sense

Paul B Mahol git at videolan.org
Fri Mar 1 16:03:40 CET 2013


ffmpeg | branch: master | Paul B Mahol <onemda at gmail.com> | Fri Mar  1 14:54:34 2013 +0000| [6c7d1608dd0cfcab99db2dd8fb0a00e410dd06b5] | committer: Paul B Mahol

sgidec: use unchecked bytestream2 functions where it makes sense

Overreads can not happen as header size of 512 bytes is required.

Signed-off-by: Paul B Mahol <onemda at gmail.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=6c7d1608dd0cfcab99db2dd8fb0a00e410dd06b5
---

 libavcodec/sgidec.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/libavcodec/sgidec.c b/libavcodec/sgidec.c
index 555b504..51bd5d6 100644
--- a/libavcodec/sgidec.c
+++ b/libavcodec/sgidec.c
@@ -169,17 +169,17 @@ static int decode_frame(AVCodecContext *avctx,
     }
 
     /* Test for SGI magic. */
-    if (bytestream2_get_be16(&s->g) != SGI_MAGIC) {
+    if (bytestream2_get_be16u(&s->g) != SGI_MAGIC) {
         av_log(avctx, AV_LOG_ERROR, "bad magic number\n");
         return AVERROR_INVALIDDATA;
     }
 
-    rle                  = bytestream2_get_byte(&s->g);
-    s->bytes_per_channel = bytestream2_get_byte(&s->g);
-    dimension            = bytestream2_get_be16(&s->g);
-    s->width             = bytestream2_get_be16(&s->g);
-    s->height            = bytestream2_get_be16(&s->g);
-    s->depth             = bytestream2_get_be16(&s->g);
+    rle                  = bytestream2_get_byteu(&s->g);
+    s->bytes_per_channel = bytestream2_get_byteu(&s->g);
+    dimension            = bytestream2_get_be16u(&s->g);
+    s->width             = bytestream2_get_be16u(&s->g);
+    s->height            = bytestream2_get_be16u(&s->g);
+    s->depth             = bytestream2_get_be16u(&s->g);
 
     if (s->bytes_per_channel != 1 && (s->bytes_per_channel != 2 || rle)) {
         av_log(avctx, AV_LOG_ERROR, "wrong channel number\n");



More information about the ffmpeg-cvslog mailing list