[FFmpeg-cvslog] tools/qt-faststart: Fix unintended sign extension of current_offset

Michael Niedermayer git at videolan.org
Sun Jun 2 23:19:02 CEST 2013


ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Sun Jun  2 23:10:44 2013 +0200| [582f36ca3fb1c69dbe3478f174d36278f5dd3f63] | committer: Michael Niedermayer

tools/qt-faststart: Fix unintended sign extension of current_offset

Fixes: CID733809

Signed-off-by: Michael Niedermayer <michaelni at gmx.at>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=582f36ca3fb1c69dbe3478f174d36278f5dd3f63
---

 tools/qt-faststart.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/qt-faststart.c b/tools/qt-faststart.c
index 489c1ab..cb36c43 100644
--- a/tools/qt-faststart.c
+++ b/tools/qt-faststart.c
@@ -240,7 +240,7 @@ int main(int argc, char *argv[])
                 goto error_out;
             }
             for (j = 0; j < offset_count; j++) {
-                current_offset  = BE_32(&moov_atom[i + 12 + j * 4]);
+                current_offset  = (uint32_t)BE_32(&moov_atom[i + 12 + j * 4]);
                 current_offset += moov_atom_size;
                 moov_atom[i + 12 + j * 4 + 0] = (current_offset >> 24) & 0xFF;
                 moov_atom[i + 12 + j * 4 + 1] = (current_offset >> 16) & 0xFF;



More information about the ffmpeg-cvslog mailing list