[FFmpeg-cvslog] lavfi/delogo: use weighted interpolation

[Michael Niedermayer]

Hi

On Fri, Jul 12, 2013 at 11:32:39AM +0200, Jean Delvare wrote:
> Hi Michael,
> 
> On Tue, 9 Jul 2013 11:55:54 +0200, Michael Niedermayer wrote:
> > On Mon, Jul 01, 2013 at 09:37:51AM +0200, Jean Delvare wrote:
> > > ffmpeg | branch: master | Jean Delvare <khali at linux-fr.org> | Wed Jun 26 14:50:37 2013 +0200| [16fd75ceec1d3915b565469d796ac4a273813bfe] | committer: Stefano Sabatini
> > > 
> > > lavfi/delogo: use weighted interpolation
> > > (...)
> > > @@ -58,8 +60,8 @@ static void apply_delogo(uint8_t *dst, int dst_linesize,
> > >                           int logo_x, int logo_y, int logo_w, int logo_h,
> > >                           int band, int show, int direct)
> > >  {
> > > -    int x, y;
> > > -    int interp, dist;
> > > +    int x, y, dist;
> > > +    uint64_t interp, weightl, weightr, weightt, weightb;
> > >      uint8_t *xdst, *xsrc;
> > 
> > it seems coverity found a minor issue with this (CID1046439)
> > not sure how real it is ...
> 
> I can't see any issue with the code but I admit I'd be curious to see
> what Coverity has to say about it.
> 
> FWIW I tested the code with sparse, and it did not find any issue in
> function apply_delogo.
> 
> > PS: ill give you access to the coverity stuff as soon as coverty
> > is fixed and accepts emails with a '-' in the domain or whatever the
> > reason why it doesnt accept it.
> 
> I used to have a Coverity account for the Linux kernel and I had to ask
> them to close it at one point because the usage conditions back (2006)
> then were incompatible with my job. I don't remember the exact details
> though... I hope this is not what is causing trouble to you right now.

seems whatever the problem was, it was fixed.
Invitation sent

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20130712/da78db8c/attachment.asc>