[FFmpeg-cvslog] rtpdec: Simplify insertion into the linked list queue

Martin Storsjö git at videolan.org
Tue Jan 15 14:40:38 CET 2013


ffmpeg | branch: master | Martin Storsjö <martin at martin.st> | Fri Dec  7 16:19:42 2012 +0200| [d0fe217e3990b003b3b3f2c2daaadfb2af590def] | committer: Martin Storsjö

rtpdec: Simplify insertion into the linked list queue

By using a pointer-to-pointer, we avoid having to keep track
of the previous packet separately.

Signed-off-by: Martin Storsjö <martin at martin.st>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=d0fe217e3990b003b3b3f2c2daaadfb2af590def
---

 libavformat/rtpdec.c |   16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/libavformat/rtpdec.c b/libavformat/rtpdec.c
index 97cfed8..1ccc0f6 100644
--- a/libavformat/rtpdec.c
+++ b/libavformat/rtpdec.c
@@ -723,15 +723,14 @@ void ff_rtp_reset_packet_queue(RTPDemuxContext *s)
 static void enqueue_packet(RTPDemuxContext *s, uint8_t *buf, int len)
 {
     uint16_t seq   = AV_RB16(buf + 2);
-    RTPPacket *cur = s->queue, *prev = NULL, *packet;
+    RTPPacket **cur = &s->queue, *packet;
 
     /* Find the correct place in the queue to insert the packet */
-    while (cur) {
-        int16_t diff = seq - cur->seq;
+    while (*cur) {
+        int16_t diff = seq - (*cur)->seq;
         if (diff < 0)
             break;
-        prev = cur;
-        cur  = cur->next;
+        cur = &(*cur)->next;
     }
 
     packet = av_mallocz(sizeof(*packet));
@@ -741,11 +740,8 @@ static void enqueue_packet(RTPDemuxContext *s, uint8_t *buf, int len)
     packet->seq      = seq;
     packet->len      = len;
     packet->buf      = buf;
-    packet->next     = cur;
-    if (prev)
-        prev->next = packet;
-    else
-        s->queue = packet;
+    packet->next     = *cur;
+    *cur = packet;
     s->queue_len++;
 }
 



More information about the ffmpeg-cvslog mailing list