[FFmpeg-cvslog] h264: Fix assignments in if()

Michael Niedermayer git at videolan.org
Mon Jan 14 16:21:54 CET 2013


ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Sun Jan 13 23:44:01 2013 +0100| [59d5680310084398dc6eb8fa62d56a7d1c9b85e0] | committer: Martin Storsjö

h264: Fix assignments in if()

Fixes null pointer dereference later, since if this function failed,
a positive return value was returned to the caller.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Martin Storsjö <martin at martin.st>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=59d5680310084398dc6eb8fa62d56a7d1c9b85e0
---

 libavcodec/h264.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/h264.c b/libavcodec/h264.c
index 3660597..f1cac2c 100644
--- a/libavcodec/h264.c
+++ b/libavcodec/h264.c
@@ -2527,7 +2527,7 @@ static int h264_slice_header_init(H264Context *h, int reinit)
             return ret;
         }
     } else {
-        if ((ret = ff_MPV_common_init(s) < 0)) {
+        if ((ret = ff_MPV_common_init(s)) < 0) {
             av_log(h->s.avctx, AV_LOG_ERROR, "ff_MPV_common_init() failed.\n");
             return ret;
         }



More information about the ffmpeg-cvslog mailing list