[FFmpeg-cvslog] sws: revert: "swscale: Remove two bogus asserts"

Reimar Döffinger Reimar.Doeffinger at gmx.de
Thu Sep 13 18:59:49 CEST 2012


On Thu, Sep 13, 2012 at 04:52:06PM +0200, Michael Niedermayer wrote:
> ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Thu Sep 13 15:53:05 2012 +0200| [0ed0f2e56600d8b404c22530a75c11b60a5380a7] | committer: Michael Niedermayer
> 
> sws: revert: "swscale: Remove two bogus asserts"

A bit more text (like explaining what they check) might not hurt,
I think taking someone misunderstanding the code as a first
approximation that it should be clarified is usually not a bad idea.

> +                av_assert1(lumSrcPtr  + vLumFilterSize - 1 < lumPixBuf  + vLumBufSize * 2);
> +                av_assert1(chrUSrcPtr + vChrFilterSize - 1 < chrUPixBuf + vChrBufSize * 2);

Why does this use -1 and < instead of just <= ?


More information about the ffmpeg-cvslog mailing list