[FFmpeg-cvslog] Add CPiA video decoder

[Reimar Döffinger]

On Fri, Aug 31, 2012 at 10:44:43PM +0200, Michael Niedermayer wrote:
> On Fri, Aug 31, 2012 at 06:22:27PM +0200, Reimar Döffinger wrote:
> > Sorry for being late in commenting.
> > 
> > > +    // Get buffer filled with previous frame
> > > +    if ((ret = avctx->reget_buffer(avctx, frame)) < 0) {
> > > +        av_log(avctx, AV_LOG_ERROR, "reget_buffer() failed!\n");
> > > +        return ret;
> > > +    }
> > [...]
> > > +    if (header[28] == NOT_COMPRESSED) {
> > > +        frame->pict_type = AV_PICTURE_TYPE_I;
> > > +        frame->key_frame = 1;
> > > +    } else {
> > > +        frame->pict_type = AV_PICTURE_TYPE_P;
> > > +        frame->key_frame = 0;
> > > +    }
> > 
> > Shouldn't this be set before reget_buffer?
> > Or rather better, reget_buffer moved after it, so as to avoid
> > getting a buffer and right after bailing out due to header errors,
> > which is at least a bit ugly.
> 
> I think Stephan is not subscribed to this mailing list

Well, it seems he did become aware of it in some way and it's changed,
thanks to everyone involved.