[FFmpeg-cvslog] doc: git-howto: Leave reviewers time to react before pushing patches

Diego Biurrun git at videolan.org
Mon Nov 12 11:50:09 CET 2012


ffmpeg | branch: master | Diego Biurrun <diego at biurrun.de> | Thu Oct 25 18:33:38 2012 +0200| [97bf7c03b1338a867da52c159a2afecbdedcfa88] | committer: Diego Biurrun

doc: git-howto: Leave reviewers time to react before pushing patches

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=97bf7c03b1338a867da52c159a2afecbdedcfa88
---

 doc/git-howto.texi |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/doc/git-howto.texi b/doc/git-howto.texi
index 68e0061..5a8e2a3 100644
--- a/doc/git-howto.texi
+++ b/doc/git-howto.texi
@@ -419,6 +419,13 @@ Also note that every single commit should pass the test suite, not just
 the result of a series of patches. So if you have a series of commits
 to push, run the test suite on every single commit.
 
+Give other developers a reasonable amount of time to look at and review
+patches before you push them. Not everybody is online 24/7, but may wish
+to look at and comment on a patch nonetheless. The time you leave depends
+on the urgency and complexity of the patch. Use your common sense to pick
+a timeframe that allows everybody that you think may wish to comment
+and/or should comment on the change an opportunity to see it.
+
 Finally, after pushing, mark all patches as committed on
 @url{http://patches.libav.org/,patchwork}.
 Sometimes this is not automatically done when a patch has been



More information about the ffmpeg-cvslog mailing list