[FFmpeg-cvslog] Fix libspeex decoding.

Clément Bœsch ubitux at gmail.com
Thu Mar 22 09:13:33 CET 2012


On Thu, Mar 22, 2012 at 06:51:26AM +0000, Carl Eugen Hoyos wrote:
> Reimar Döffinger <Reimar.Doeffinger <at> gmx.de> writes:
> 
> > >          avctx->sample_rate = s->header->rate;
> > >          avctx->channels    = s->header->nb_channels;
> > > +                             s->frame_size = s->header->frame_size;
> > 
> > The indentation is way off?
> 
> It's intentional, because before 85469f, the code was 
>              avctx->frame_size  = s->frame_size = ...
> 
> Do you think it's unreadable / insane and I should change it?
> 

I think it's confusing; if you want to mark the fact it is not related to
avctx attributes assignments, just add a \n.

Right now we might be wondering if it's not a mistake such as forgotten
'=' in the previous line or anything that make suggest a relationship with
previous code.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20120322/ba6c78b9/attachment.asc>


More information about the ffmpeg-cvslog mailing list