[FFmpeg-cvslog] wmaenc: remove bit-exact hack

Justin Ruggles git at videolan.org
Sat Mar 17 23:52:40 CET 2012


ffmpeg | branch: master | Justin Ruggles <justin.ruggles at gmail.com> | Sat Mar 17 11:42:49 2012 -0400| [c3da9f506038aea306dd1b9ce48db94ca251a08d] | committer: Justin Ruggles

wmaenc: remove bit-exact hack

It may have improved cross-platform stability, but wasn't the only place in
the encoder with bitexact issues. It is no longer needed because we have FATE
tests for float encoders using fuzzy comparison.

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=c3da9f506038aea306dd1b9ce48db94ca251a08d
---

 libavcodec/wmaenc.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/libavcodec/wmaenc.c b/libavcodec/wmaenc.c
index 6fd3494..b9c40d8 100644
--- a/libavcodec/wmaenc.c
+++ b/libavcodec/wmaenc.c
@@ -306,10 +306,6 @@ static int encode_block(WMACodecContext *s, float (*src_coefs)[BLOCK_MAX_SIZE],
                         if(1<<coef_nb_bits <= abs_level)
                             return -1;
 
-
-                        //Workaround minor rounding differences for the regression tests, FIXME we should find and replace the problematic float by fixpoint for reg tests
-                        if(abs_level == 0x71B && (s->avctx->flags & CODEC_FLAG_BITEXACT)) abs_level=0x71A;
-
                         put_bits(&s->pb, coef_nb_bits, abs_level);
                         put_bits(&s->pb, s->frame_len_bits, run);
                     }



More information about the ffmpeg-cvslog mailing list